Resolve issues found in reviewed PRs 4699, 4703, 4711 [, ...] #4731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CoreTradesService was refactored to work for newly added api methods: - keepfunds -- close trade, keep funds in bisq wallet - withdrawfunds -- close trade, withdraw funds to external btc wallet A getKey accessor was added to CoreWalletsService (needed by withdrawfunds impl).
Some refactoring of the api test case hierarchy is included in this commit.
This commit fixes non-trade tests broken by the last refactoring.
The implementation will be added to CoreOffersService in the next PR.
This upgrades jupiter for all subprojects using this library, but it does not affect released code.
- Show full stack traces in console - Do use previously cached test outputs - Do not show skipped test name in console (too noisy) - Show test run summary, including number of skipped tests - Show note about skipped test info in the html report - Show link to html report on test SUCCESS
- Remove dead code from AbstractLinuxProcess. - Make default dummy accts static in MethodTest. - Simplify gRPC stub creation, btc block generation, dispute agent registration, and dummy acct initialization in test case startup. - Make ExpectedProtocolStatus visible to scenario test pkg.
Consolidated all method tests into fewer test cases by running them from new 'scenario' test cases. This cuts the current scaffold setup & teardown times by almost 1/2. No method tests were deleted or duplicated. (1) Disabled all method (unit) test cases at the class level. (2) Added new scenario test cases to run all disabled test cases (1). The method test cases can still be run by commenting out the @disabled annotation.
These changes were requested in review of PR bisq-network#4699
These changes were requested in review of PR bisq-network#4699
This change resolves issue found in PR review. See bisq-network#4703 (comment)
ghubstan
changed the title
ghubstan
changed the title
This change was requested in chimp1984@961703e This replaces and closes PR bisq-network#4558
…instance This change requested at bisq-network#4711 (comment)
ghubstan
changed the title
sqrrm
approved these changes
Nov 2, 2020
| if (trade == null) | ||
| return ""; | ||
|
|
||
| Offer offer = trade.getOffer(); |
There was a problem hiding this comment.
This is not required, but I do like the notation
Offer offer = checkNotNull(trade.getOffer());
ghubstan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A chain of 18 PRs are being reviewed in parent-branch -> child-branch order, and the reviewer agreed to allow me to put requested changes into its own PR branch -- this one, the final branch of the chain.
The first two commits resolve issues in #4699, #4703, #4711
When all issues in the PR chain are resolved here, this PR will move from draft to ready for review status.